Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove javafx.swing module

See original GitHub issue

javafx.swing module is used by JavaFXThreadingRule. This class in turn is used by CheckTreeViewTest.

IMO, it would be a good idea to get rid of both these classes and remove the dependency of ControlsFX on javafx.swing.

This will also provide us a clean slate to introduce testing for ControlsFX on 9.0.0 branch.

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

abhinayagarwalcommented, Apr 14, 2020

Now that the JavaFXThreadingRule is fixed, I will assign the issue and take care of removing the javafx.swing module from the application. Thanks for your help @Maxoudela

1reaction

abhinayagarwalcommented, Apr 12, 2020

We use TestFX to run some tests on master branch. I has removed it from 9.0.0 because I wasn’t able to run them using JDK 11 and JPMS.

Nevertheless, I have fixed it and brought back the tests which were based on TestFX.

Since my experience with TestFX is minimum, is it OK to assign the issue to you so that you can have a look at CheckTreeViewTest and do the needful? If not, I can have a look at TestFX later and fix it.