Types can't have dashes

The header pattern here: https://github.com/conventional-changelog/conventional-changelog/blob/09b1a0a57bcee4628b4c0b20920079d055f34a70/packages/conventional-commits-parser/index.js#L9

…doesn’t allow for a type of new-feature, but seemingly otherwise things would have worked.

Not a huge deal but if you’d prefer dashes not be allowed in types, then perhaps an error should be thrown? alternatively, update the regex.

downstream: https://github.com/GoogleChrome/lighthouse/pull/3534

[Jack-Barry]

If anyone else hits this, I’m using the following to get this to play nice with the output from cz-emoji with the conventional flag set to true:

commitlint.config.js

const commitTypes = require('cz-emoji/lib/types.json')

module.exports = {
  extends: ['@commitlint/config-conventional'],
  rules: {
    'type-enum': [2, 'always', commitTypes.map((type) => type.name)],
  },
  parserPreset: {
    parserOpts: {
      headerPattern: /^((?:\w|-)*)(?:\((.*)\))?!?: (.*)$/,
      breakingHeaderPattern: /^((?:\w|-)*)(?:\((.*)\))?!: (.*)$/,
    },
  },
}

The trick is changing the first capture group in the regex from (\w*) (as found in parser-opts.js) to ((?:\w|-)*)

This approach could be stupid, I’m not sure. But it works 🤷

[stevemao]

@marionebl new-audit is not a valid types because it’s not a single word. I believe they just want to use sensible defaults. Point is it’d be really good we could print better error/warning in general 😄