Add constant components in top-level component
See original GitHub issueIdea:
To make a united layout throughout the app.
- Include top-level components like navbar, constant images like logos in a top-level component such as
Layout.js
. Remove them from DiagnosticContainer component - Use Material-UI theming
- As per @friedger and @AdhamAH suggestions, keep constant components in Layout.js’ and React providers in ‘App.js’
Motivation:
- Keep consistency in the styling of the app
- Make it easier for anyone new coming on board to follow the same flow
- Start implementing Material-UI
Issue Analytics
- State:
- Created 3 years ago
- Comments:11 (11 by maintainers)
Top Results From Across the Web
React Hook inside constant - Stack Overflow
I am beginner I think I have to use component for it but I'm not sure how to import routes constant from component....
Read more >Top-level statements - C# tutorial - Microsoft Learn
This tutorial shows how you can use top-level statements to experiment and prove concepts while exploring your ideas.
Read more >Guide to components in Figma
Overview. Components are elements you can reuse across your designs. They help to create and manage consistent designs across projects.
Read more >12 Customize Variables and Constants - Oracle Help Center
Variables and constants store static values and expressions that are used in components and pages. For example, they might be used to store...
Read more >How to use Constants and Generic Map in VHDL - VHDLwhiz
Learn how to use Constants and Generic Map to make your VHDL modules ... It allows you to make certain parts of the...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I think it is good practise to put all the react providers in
App.js
and the constant components into something likeLayout.js
, then the components for all routes can make use ofLayout
as top level component.I think anything top-level like this could go within
App.js
, unless that’s bad practice, not too sure.I was thinking
DiagnosticContainer
would be the wrapper component for the Health Log, containing both the overview and also weekly view. I don’t know if we should repurpose this.