Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix / Implement setModalHidden

See original GitHub issue



We currently have a function setModalHidden in Disclaimer.js that causes our program to error out on startup as it’s not implemented anywhere.

We should implement this functionality so that disclaimer behaves properly, or remove it entirely for the time being.

Steps to Reproduce

  1. Start up application

Expected behavior:

The application runs

Actual behavior:

The application errors out

Reproduces how often:


Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:14 (14 by maintainers)

github_iconTop GitHub Comments

Tanvezcommented, Mar 26, 2020

Sorry for the confusion! I meant locally without redux for now. Since the disclaimer component is only using state to toggle the modal on and off. Edit: Nvm I think i get what y’all are saying will go ahead with redux

SomeMooserycommented, Mar 26, 2020

Yeah I think we’d want to persist this application to the database so that the user only has to agree once, and then on subsequent logins we’d query the database to see if the logged-in user has already consented or not. So, it seems like Redux would be applicable here, right?

Good point on not necessarily requiring Redux for simple like intra-component functionality that doesn’t need to persist across components or in the database, though, @fallon7284

Open to thoughts/ideas though!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to hide Bootstrap modal with javascript? - Stack Overflow
With the modal open in the browser window, use the browser's console to try $('#myModal').modal('hide');. If it works (and the modal closes) then...
Read more >
modal('show') after a modal('hide') doesn't work #3902 - GitHub
The hideModal function sets a flag that it is currently hiding a modal. When it is done it resets the flag. If a...
Read more >
Modal - Bootstrap
Modals use position: fixed , which can sometimes be a bit particular about its rendering. Whenever possible, place your modal HTML in a...
Read more >
Considerations for Styling a Modal | CSS-Tricks
I find it highly tempting to make the default .modal class be hidden by default, likely with display: none; . Then to open...
Read more >
Bootstrap Modal Dialog showing under Modal Background
The easiest solution is to move the modal dialog outside of any container and just declare it under the <body> element, or -...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found