Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Sitemaps] Sitemap index: stop URL at closing </loc>

See original GitHub issue

(cf. Nutch mailing list

With #153 the sitemaps SAX parser handles sitemaps with missing or not properly closed <url> elements. This should be also done for sitemap indexes, e.g.:

<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex>
<sitemap>
<loc>https://www.example.orgl/sitemap1.xml</loc>
<loc>https://www.example.org/sitemap2.xml</loc>
</sitemap>
</sitemapindex>

Issue Analytics

State:
Created 5 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

2reactions

kkruglercommented, Dec 12, 2018

Hi @sebastian-nagel - got it, there are two <loc> elements in a row. I thought that was valid, due to how SiteMapIndex has an list of SiteMap records, each of which has a list of SiteMapURL records. Seems like we’re abusing the SiteMap class in this situation, we really want another concrete version of AbstractSiteMap that only has a single URL.

0reactions

sebastian-nagelcommented, Dec 13, 2018

The sitemap index given above is invalid, it does not follow the spec. However, as the parser is designed to parse also invalid sitemaps it should be able to parse also invalid sitemap indexes and silently try to fix their structure by assuming </sitemap><sitemap> between the two <loc> elements. The SiteMapHandler class also auto-closes <url> elements. I’ll open a PR to address it.