Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Incorrect domains returned by EffectiveTldFinder

See original GitHub issue

The method EffectiveTldFinder.getAssignedDomain(hostname) returns an incorrect domain in a couple of cases. This was detected by a comparison with the Python module tldextract which is also based on the public suffix list.

  1. exceptions to wildcard rules are not recognized as valid domain, e.g. with the rules


    the domain for “” should be “”.

  2. the domain detection fails entirely of the .za top-level domain: “” should give “”. A test whether the last element “za” is a valid TLD fails but the .za registrar does not allow .za alone as TLD.

  3. detection fails for internationalized domain names in their punycoded (ASCII) form: for “спб.бесплатныеобъявления.рф” the domain “бесплатныеобъявления.рф” is correctly returned but not for the punycode equivalent “спб.бесплатныеобъявления.рф”. The public suffix list contains the utf-8 representation of IDNs and must be (additionally) transposed to the ASCII/Punycode form.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

sebastian-nagelcommented, Oct 17, 2017

Let me work on it today. Merging fails and I’ll try to get a PR ready today evening.

sebastian-nagelcommented, Oct 17, 2017

Done, except for IDNs which do not get processed. The puny-coded form however works. I’ll open a separate issue for this, requires more changes, esp. to handle mixed usage of IDN and punycoded parts.

Read more comments on GitHub >

github_iconTop Results From Across the Web

EffectiveTldFinder throws IllegalArgumentException on IDN ...
EffectiveTldFinder throws an IllegalArgumentException when parsing domain names containing characters prohibited in Internationalized Domain ...
Read more >
Troubleshooting Domain Controller Deployment
Domain controller promotion and demotion always returns a code at the end of operation and unlike most programs, don't return zero for success....
Read more >
Problem with removing a child domain in an Active Directory ...
Resolving The Problem​​ - Click Start, click Run, type ntdsutil, and then press ENTER. - At the Ntdsutil command prompt, type domain management, ......
Read more >
Fix conflicting records errors - Google Domains Help
Invalid record count. Before you begin. Certain records don't interact well with each other and may cause problems. Before troubleshooting the error messages, ......
Read more >
Sending Domains API - SparkPost Developers
The request will return an extra attribute, dns , which contains the DNS values or error if there was a problem validating the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found