[Bug] Site Toggle, Site List, & More Tabs Broken
See original GitHub issueBug Report
Website Address
Example Site Used for screenshots/screen recordings: https://github.com/darkreader/darkreader/ Issue applies to All Sites though
Bug Description
When using the Site Toggle shortcut key combo, or clicking on the Dark Reader Extension icon and then the site name, the site doesn’t change from dark to light mode or vice versa. The Site list page also only displays “Invert Listed Only” and “Not Invert Listed” table headers with no cells bellow them. The More tab is also blank. Disabling and re-enabling the extension, restarting Chrome, or using Incognito Mode doesn’t fix the issue. I’ve had this issue happen once before and after clearing out all the extensions data files (local and synced) and then reinstalling the extension, the issue is fixed, but I lose my configured site list. This issue just came back again after about a week of no issues. I checked the Console log before I cleared the extension data last time (but didn’t copy the error down) and noticed an error that I believe is similar to the error I’m seeing now:
Uncaught (in promise) TypeError: props.values.map is not a function
at TextList (index.js:3417:18)
at ComponentVNode.unbox (index.js:649:27)
at ComponentVNode.attach (index.js:681:34)
at execute (index.js:395:19)
at index.js:396:45
at Array.forEach (<anonymous>)
at execute (index.js:396:30)
at index.js:396:45
at Array.forEach (<anonymous>)
at execute (index.js:396:30)
The last time this issue happened, it spread (site list is being synced between clients using my same signed in Google account Chrome profile) and affected my work Macbook (Chrome) and also my 2 personal Windows 10 Computers (Chrome). Currently as i’m writing this, the issue is only on my Mac Chrome browser, but could spread to my Windows computer after the next time Chrome decides to sync its extension data.
This issue may be similar to Bug #8439, but on macOS at least, local .html and .pdf files are protected and can’t be modified by Dark Reader, so i couldn’t reproduce the issue on my machine in a new Chrome profile.
Steps To Reproduce
- Start with a fresh install of Dark Reader
- Use the extension for X period of time, accessing various sites/files and adding various sites to local site list
- ???
- Extension breaks until i clear the extension data
- Repeat
Expected Behavior
Dark Reader works as normal, allowing me to toggle individual sites between dark and light mode
Actual Behavior
Dark Reader randomly stops working until extension data is cleared out, losing personal site list
Screenshots
System Information
- OS: macOS & Windows
- Browser: Chrome 99.0.4844.74 (Mac) Chrome 99 (Windows)
- Dark Reader Version: 4.9.47
Additional Context
- Dark Reader was installed directly from Chrome Web Store and was the official extension.
- You may notice I have uBlock Origin installed also, disabling uBlock Origin doesn’t change anything when Dark Reader is in a broken state.
- I’m leaving Dark Reader broken on my Mac (and likely to soon be broken on my Windows computers as well) so further troubleshooting can be done.
- This is my first Github bug on a public project, I tried to be as thorough as possible with my bug report, but please let me know if there is any additional info I should add, or formatting tips for future bug reports. Thanks!
Issue Analytics
- State:
- Created 2 years ago
- Reactions:1
- Comments:14 (4 by maintainers)
Top GitHub Comments
Just experienced this issue, after a recent chrome update, but I did not locate this issue before removing and re-installing to restore functionality. If this issue occurs again I will capture and share the output from console.
Seems like a couple of issues are going on here, would need to take a deeper dive in how this can happen and how to correctly prevent such issue without messing up current settings 😅.