Add sorting menu to the Bid Selection screen
See original GitHub issueThank you for your help ❤️
What is this project?
DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.
As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.
Missions
The DAV project you are looking at is Missions. Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.
How you can help
The Issue
We want to improve the current ‘Bid Selection’ screen (that appears when ordering a pickup) and allow users to sort the results by price, time of arrival etc., see mockup examples:
The current version does not include the icon to open the sort options, or the sorting options themselves. Both need to be added, as well as the sorting logic itself.
Available sorting options:
- Best match - Default selection. A combination of fastest pickup and lowest cost, with preference for fastest pickup (meaning, the items with the fastest pickup will be shown first, and in case of bids with similar pickup time, we’ll show the one with the lowest price first)
- Fastest pickup - Sort by the shortest ETA at the pickup location
- Fastest delivery - Sort by the shortest ETA at the dropoff location
- Lowest cost - Sort by lowest price
UI behaviour:
- Pressing the sort button on the right hand side will slide the ‘sort by’ menu from the top down
- The selected choice should be highlighted, accompanied with a green checkmark
- Selecting a different choice will roll down the menu and refresh the results
- Pressing on X button will simply roll down the menu (no changes)
See attached zip file with the new icons in svg format: icons_svg.zip
Contributing to Missions
- Make sure this issue is labeled
up-for-grabs
and not labeledclaimed
, to verify no one else is working on it. - Comment in this issue that you would like to do it.
- Open the Missions GitHub page and click the ★ Star and then ⑂ Fork buttons.
- Clone a copy to your local machine with
$ git clone git@github.com:YOUR-GITHUB-USER-NAME/missions.git
- Make changes in the LICENSE file
- Once you’ve made sure all your changes work correctly and committed all your changes, push your local changes back to github with
$ git push -u origin master
- Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missions) and create a pull request for your changes.
- Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this:
#5
) - Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.
Asking for help
We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
Top GitHub Comments
@TalAter Sure thing! After this pr is merged right ? Will keep a track of this!
Re @pfreema1 question in gitter:
I think we can open a new task for that. Hope that answers your question.