question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove unnecessary return statement

See original GitHub issue

first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before and are looking for an easy way take their first steps.

Consider this as your chance to dip your toe into the world of open-source and get some bragging rights for writing code that makes drones fly, cars find charging stations, helps people and goods move from place to place and more…

Find more first-timers-only issues from DAV Foundation here.

Thank you for your help ❤️

What is this project?

DAV (Decentralized Autonomous Vehicles) is a new non-profit foundation working to build an open-source infrastructure for autonomous vehicles (cars, drones, trucks, robots, and all the service providers around them) to communicate and transact with each other over blockchain.

As an organization that believes in building a large community of open-source contributors, we often create issues like this one to help people take their first few steps into the world of open source.

Missions

The DAV project you are looking at is Missions. Missions is the client facing side of the marketplace connecting DAV users looking to ship packages, with autonomous vehicles such as drones.

How you can help

The Issue

Within utils.js there is a function called shiftCoords(). At the end of this function is a return undefined; statement. This isn’t needed, as a function would return undefined anyway if we don’t return anything. You can delete this line and help keep the file size smaller for mobile audiences 👍

Contributing to Missions

  • Make sure this issue is labeled up-for-grabs and not labeled claimed, to verify no one else is working on it.
  • Comment in this issue that you would like to do it.
  • Open the Missions GitHub page and click the ★ Star and then ⑂ Fork buttons.
  • Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/missions.git
  • Make changes in the package.json file
  • Once you’ve made sure all your changes work correctly and committed all your changes, push your local changes back to github with $ git push -u origin master
  • Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/missions) and create a pull request for your changes.
  • Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: #5)
  • Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community and the foundation. If you need any help, feel free to ask below or in our gitter channel. We are always happy to help 😄

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
griffobeidcommented, Jan 24, 2018

It’s all yours @Apoorva-13 👍 Let me know if you have any questions.

0reactions
griffobeidcommented, Jan 27, 2018

@BismeetSingh Ya, @Apoorva-13 already finished this issue. Just waiting for it to get merged.

Sent with GitHawk

Read more comments on GitHub >

github_iconTop Results From Across the Web

no-useless-return - ESLint - Pluggable JavaScript Linter
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior ... This rule aims to report...
Read more >
Code Inspection: Unnecessary 'return' statement - JetBrains
Suppress an inspection in the editor · Position the caret at the highlighted line and press Alt+Enter or click the Intention action icon...
Read more >
Disallow redundant return statements (no-useless-return)
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function. This can be...
Read more >
How do I avoid a useless return in a Java method?
Use a temp variable, for instance "result" , and remove the inner return. Change the for loop for ...
Read more >
no-useless-return removes return statements in unreachable ...
I added a throw statement to the top of my function to aid debugging, and the critical return statement from later in the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found