Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
[SEMANTIC-59] [Bug] metric_jsonschema_example still references old properties in required fields
See original GitHub issueIs this a new bug in dbt_metrics?
- I believe this is a new bug in dbt_metrics
- I have searched the existing issues, and I could not find an existing issue for this bug
Current Behavior
Currently, the metric_jsonschema_example.json file still references the type and sql properties.
"required": ["name","label","timestamp","time_grains","type","sql"],
Expected Behavior
It should be updated with the new properties, calculation_method and expression
Steps To Reproduce
- View the source here
Relevant log output
No response
Environment
main branch
Which database adapter are you using with dbt?
No response
Additional Context
Happy to submit a PR to fix this.
Issue Analytics
- State:
- Created a year ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
No results found
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I would like to submit the PR, if you do not mind. I am just about ready to create it. Keen to make my first PR for OSS.
Here is the PR: @callum-mcdata (I can’t seem to tag you as a reviewer, for some weird reason)