question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consistent behavior for escape button

See original GitHub issue

On macOS, when the ‘Merge Into Current Branch’ (⇧⌘M) modal is open, it cannot be closed with the <kbd>esc</kbd> button.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

1reaction
shiftkeycommented, Dec 28, 2018

@koralcem I think the Merge into current branch dialog was fixed in #6236 but I’m going to ask @tierninho to confirm that they can’t find any more dialogs that behave like this before we close it out.

1reaction
tierninhocommented, Oct 12, 2018

@shiftkey I found some other modals (with the filter focus intact) where we allow the esc key to work. Try ⌘N and ⌘O.

Seems like a bug and good first issue, if you agree.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Make ESC key behavior consistent across description ... - Jira
What happens currently when editing a description is that your edits are discarded if the Escape key is pressed. There are many reasons...
Read more >
ToolStripDropDownButton - changing dropdown behavior with ...
The objective is for a user to cancel his selection by hitting the escape key. The problem is that the DropDownClosed event also...
Read more >
Lightroom Classic. [Esc] key functionality is diff... - 12342387
Escape key should and does escape (cancel) any current dialog or user ... To me, that is the inconsistent behavior, because in no...
Read more >
Combobox: Escape key should not clear current input #1066
Escape key usually means "Abort what you are currently doing". From that point of view clearing is definitely an unwanted side effect. Native ......
Read more >
Support keyboard interaction | Digital Accessibility​
The easiest way to implement this is by providing a keyboard command, such as pressing the escape key, to close the content. The...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found