"create a pr" always creates it against master
See original GitHub issueDescription
I just realized this… After creating a branch based on another branch than default/master and doing changes to it. When I wanted to PR my changes from the client, it opens the webpage but is showing the wrong base branch and wants to merge the branch into master (always master it looks like?).
This could easily result in a very weird PR being created. 😃
Maybe this is a repo specific workflow and one generally doesn’t want to merge changes back to a branch he created his branch off? But always want to merge to master?
To improve my workflow:
GitHub Desktop should send to the create pr webpage with correctly comparing the new created branch against the initial branch (which can be different than master):
The link should be: (source)
https://github.com/{username}/{repo}/compare/{target-branch}...{source-branch}
(Damn it, I’m really sorry… before creating an issue I always check and try to find duplicates. And it looks like I always miss them. For this, I couldn’t find one either. 😄 )
Version
GitHub Desktop version: 1.0.12 OS version: Microsoft Windows [Version 10.0.16299.125]
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (5 by maintainers)
Top GitHub Comments
I’m 👎 on over-complicating this flow here, and following what GitHub The Website does when it’s creating a pull request.
Any objections @desktop/core @desktop/comrades?
I didn’t hear any objections about the proposal to follow what GitHub the Website does, so I’m going to close this out.