question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

"create a pr" always creates it against master

See original GitHub issue

Description

I just realized this… After creating a branch based on another branch than default/master and doing changes to it. When I wanted to PR my changes from the client, it opens the webpage but is showing the wrong base branch and wants to merge the branch into master (always master it looks like?).

This could easily result in a very weird PR being created. 😃

Maybe this is a repo specific workflow and one generally doesn’t want to merge changes back to a branch he created his branch off? But always want to merge to master?

To improve my workflow: GitHub Desktop should send to the create pr webpage with correctly comparing the new created branch against the initial branch (which can be different than master): The link should be: (source) https://github.com/{username}/{repo}/compare/{target-branch}...{source-branch}

(Damn it, I’m really sorry… before creating an issue I always check and try to find duplicates. And it looks like I always miss them. For this, I couldn’t find one either. 😄 )

Version

GitHub Desktop version: 1.0.12 OS version: Microsoft Windows [Version 10.0.16299.125]

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

4reactions
shiftkeycommented, Feb 28, 2018

I’m 👎 on over-complicating this flow here, and following what GitHub The Website does when it’s creating a pull request.

Any objections @desktop/core @desktop/comrades?

0reactions
shiftkeycommented, Mar 26, 2018

I didn’t hear any objections about the proposal to follow what GitHub the Website does, so I’m going to close this out.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Creating a pull request - GitHub Docs
Create a pull request to propose and collaborate on changes to a repository. These changes are proposed in a branch, which ensures that...
Read more >
How to create an empty master and raise a PR from existing ...
Just create a branch name. That's all there is to it, really. Pick some existing commit and make the branch name master identify...
Read more >
How to make your first pull request on GitHub - freeCodeCamp
Let's make our first pull request! · 1. Fork the repository · 2. Clone the repository · 3. Create a branch · 4....
Read more >
More ways to keep your pull request branch up-to-date
Update your pull request branch by rebasing​​ To update by rebasing, click the drop down menu next to the Update Branch button, click...
Read more >
Git Pull Request (PR) - How to create a new branch - YouTube
In this video we are gonna discuss the below topics.1. How to create a new branch.2. What is Pull Request.3. Raise and review...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found