question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Desktop on Mojave (Electron 3) should not advertise itself as having a tab bar

See original GitHub issue

This doesn’t make sense for two reasons:

  • Desktop doesn’t support a tabbed interface, so this is probably always disabled for us
  • as this is rendered before the menu items in build-default-menu.ts I suspect these are some new defaults added in Mojave

The relevant area for our Desktop settings is here:

https://github.com/desktop/desktop/blob/37b420abfd08f82bf419dcbc1a5b6434a8f61a11/app/src/main-process/menu/build-default-menu.ts#L145-L153

Opening this up for someone who knows more about macOS to dive into what the app should do and what Electron apps should do to advertise they don’t support a tabbed interface.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
shiftkeycommented, Feb 13, 2019

@agisilaos I believe you’ll need to run #6713 (which contains the upgrade) to see this change yourself. It hasn’t made it to beta yet.

0reactions
shiftkeycommented, Feb 15, 2019

I’ve just released 1.6.3-beta1 on the beta channel on macOS 10.14.3 and after installing that build locally I don’t see the problem 🤦‍♂️:

screen shot 2019-02-15 at 12 58 39 pm

Closing this out as unable to reproduce, but if anyone else is able to spot this please comment here and we can try and dig into it further.

Read more comments on GitHub >

github_iconTop Results From Across the Web

macOS: App icon remaining in Dock even after closing app
macOS Mojave introduced a feature to show recently launched app's icons in the Dock, even after quitting the app. To a new user...
Read more >
1. Folders, Windows & Finder Tabs - macOS Mojave
They can hide themselves.​​ The on/off switch for this menu-hiding feature is in System Preferences → General; turn on “Automatically hide and show...
Read more >
macOS Mojave A Guide to Your System Preferences
Show Scroll Bars You can adjust how scroll bars in macOS behave. By default, they are not visible, but show automatically when you...
Read more >
macOS Mojave: The MacStories Review
News is an interesting contrast to Home. Instead of moving its iPhone tab bar to the Mac app's title bar like Home does,...
Read more >
There is unexpected "Show Tab Bar" menu item on macOS ...
The Show Tab Bar menu item is inconsistent with team tabs. Steps to reproduce. Environment. OS X 10.12; Mattermost Desktop App version: 3.4.1 ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found