question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Odd UI performance issues when committing

See original GitHub issue

Description

I’ve seen a few issues relating to performance although not seeing anything similar to what I am having. Generally, the app seems to be performing great, I can switch branches etc. fine, preview/stage changed files etc.

However, when committing changes that’s when I get some odd behaviour. Typing the message etc. is fine no issues there. However, when I commit the message the commit happens generally straight away. However, the UI seems to take a couple seconds longer to update, my comments etc remain filled out then eventually clear once 2 - 3 seconds have passed.

I don’t have any hooks associated with my repo, it’s a public Github repository. Pushing changes is also fine no performance issues there.

I’ve included a performance profile below, not sure if this includes screenshots (not really used exported a profile) as the screenshots clearly show the UI lag that exists. I’ve also included a gif that shows the issue.

I’m also getting a similar issue, with different non-public (and different repo host) repositories on my work machine, which is also High Sierra.

Edit: I don’t seem to have the long wait times when doing it via git directly in terminal.

Version

  • GitHub Desktop: 1.2.6
  • Operating system: macOS High Sierra 10.13.6

Steps to Reproduce

  1. Open a repo in Github Desktop (as this is an open source project you could try using the same repo, see if that helps reproduct. repo is BulmaJS)
  2. Make some changes
  3. Stage and write a commit message
  4. Commit the changes - either by clicking the button or pressing command+enter
  5. Commit seems to happen fairly quick, but the UI take a little time to update

Expected Behavior

I expect the commit messages to dissapear at the same time the commit is made. This is normal and used to be the case.

Actual Behavior

The commit is made (shown by the small section below the commits popping up) but the messages remain in the boxes for a couple or more seconds.

Additional Information

Profile-20180727T213817.json.zip

jul-27-2018 21-52-31

Logs

2018-07-27.desktop.production.log

Ignore the errors relating to the lock file, this was me being impatient lol.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
billygriffincommented, Sep 21, 2018

Thanks for the update, really appreciate it!

1reaction
VizuaaLOGcommented, Sep 21, 2018

@billygriffin no haven’t experienced it at work recently. And don’t remember having it with other projects either. If I still have it I’ll try re-cloning the repo. Just in case something odd is happening there.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Improve the performance of viewing large commit diffs - GitLab
I can't scroll through the page, and Gitlab's UI becomes totally unusable. The right behavior is probably to truncate the commitdiff at maybe ......
Read more >
Weird UI rendering performance #110601 - microsoft/vscode
As you can see in the pictures, once opened a rendering problem is present, doing the editor is uncompfortable to be used.
Read more >
Fix the slow render before you fix the re-render - Kent C. Dodds
Typically, the slowest part of this is the "commit" phase when the DOM is updated. But not all DOM updates are slow. In...
Read more >
Top 10 most common Java performance problems
Over those 13 years I saw my fair share of performance-related issues, and I noticed a disturbing trend: Most performance issues in Java...
Read more >
Performance impact when issuing multiple commits without ...
Definitely commits are overhead to the database, A commit consumes additional resource and runs slower. In certain cases it may cause data ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found