Odd UI performance issues when committing
See original GitHub issueDescription
I’ve seen a few issues relating to performance although not seeing anything similar to what I am having. Generally, the app seems to be performing great, I can switch branches etc. fine, preview/stage changed files etc.
However, when committing changes that’s when I get some odd behaviour. Typing the message etc. is fine no issues there. However, when I commit the message the commit happens generally straight away. However, the UI seems to take a couple seconds longer to update, my comments etc remain filled out then eventually clear once 2 - 3 seconds have passed.
I don’t have any hooks associated with my repo, it’s a public Github repository. Pushing changes is also fine no performance issues there.
I’ve included a performance profile below, not sure if this includes screenshots (not really used exported a profile) as the screenshots clearly show the UI lag that exists. I’ve also included a gif that shows the issue.
I’m also getting a similar issue, with different non-public (and different repo host) repositories on my work machine, which is also High Sierra.
Edit: I don’t seem to have the long wait times when doing it via git directly in terminal.
Version
- GitHub Desktop: 1.2.6
- Operating system: macOS High Sierra 10.13.6
Steps to Reproduce
- Open a repo in Github Desktop (as this is an open source project you could try using the same repo, see if that helps reproduct. repo is BulmaJS)
- Make some changes
- Stage and write a commit message
- Commit the changes - either by clicking the button or pressing command+enter
- Commit seems to happen fairly quick, but the UI take a little time to update
Expected Behavior
I expect the commit messages to dissapear at the same time the commit is made. This is normal and used to be the case.
Actual Behavior
The commit is made (shown by the small section below the commits popping up) but the messages remain in the boxes for a couple or more seconds.
Additional Information
Profile-20180727T213817.json.zip
Logs
2018-07-27.desktop.production.log
Ignore the errors relating to the lock file, this was me being impatient lol.
Issue Analytics
- State:
- Created 5 years ago
- Comments:8 (5 by maintainers)
Top GitHub Comments
Thanks for the update, really appreciate it!
@billygriffin no haven’t experienced it at work recently. And don’t remember having it with other projects either. If I still have it I’ll try re-cloning the repo. Just in case something odd is happening there.