Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Opens a new chrome tab on ]

See original GitHub issue

Description

With hungarian layout pressing the ] character is done with altgr+G which the Github application catches as ctrl+alt+g which opens a chrome tab.

Version

GitHub Desktop version: 0.8.0

OS version: Microsoft Windows [Version 10.0.15063]

Steps to Reproduce

Press alt gr+G

Expected behavior: It does not open a chrome tab.

Actual behavior: Opens a chrome tab.

Reproduces how often: Every time 😃

Issue Analytics

State:
Created 6 years ago
Comments:9 (6 by maintainers)

Top GitHub Comments

2reactions

lee-dohmcommented, Sep 11, 2017

We had to move away from Ctrl+Alt shortcuts in Atom for the same reason.

1reaction

shiftkeycommented, Sep 11, 2017

Looks like this is a Windows Intended Behaviour, and our choice of shortcut here isn’t helpful. From Raymond Chen’s blog:

You may have noticed that Windows doesn’t use Ctrl+Alt as a keyboard shortcut anywhere. (Or at least it shouldn’t.) If a chorded modifier is needed, it’s usually Ctrl+Shift.

That’s because Ctrl+Alt has special meaning on many keyboards. The combination Ctrl+Alt is also known as AltGr, and it acts as an alternate shift key. For example, consider the German keyboard layout. Notice that there are three keyboard shift states (Normal, Shift, and AltGr), whereas on U.S. keyboards there are only two (Normal and Shift). For example, to type the @ character on a German keyboard, you would type AltGr+Q = Ctrl+Alt+Q. (Some languages, like Swedish, have a fourth state: Shift+AltGr. And then of course, there’s the Japanese keyboard…)

@desktop/core I think we should change this to be <kbd>Ctrl + Shift + G</kbd> to align with all our other shortcuts. I don’t think this clashes with an existing shortcut, but I’ll confirm as part of the PR process.