Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[RBB] Compare to Branch

See original GitHub issue

This is part of #3956 and is for viewing changes as compared to any branch (ex: master).

Changes:

create a feature flag (ideally we don’t change anything in the HistorySideBar component)
copy change (history -> compare, changes -> commit [may not be reflected in mocks, talk to @niik])
branch selecting input with new icon in input
list of branches on branch selecting input click (if it’s empty) which can be "x"ed out
clicking on a branch shows commits ahead of the target branch
filtering

User Flow to check functionality:

click on compare tab and see the commits you made on your branch + all commits from where you branched off of (existing behavior)
click into the “compare a branch…” input and see a list of branches just like you would for switching branches if you clicked on the “current branch” menu item
click on “master” and “master” becomes the text in the input and you see all the commits you have ahead of “master”
press “x” in the branch input and see list of branches again
select another branch, ex: “new-branch” and “new-branch” becomes the text in the input and you see all the commits you have ahead of “new-branch”
press “x” in the branch input and see list of branches again
start typing the name of an existent branch in “compare a branch…” input
see all branches filtered with same behavior as we have for the branches container
select a new target branch, ex: “filtered-branch” and “filtered-branch” becomes the text in the input and you see all the commits you have ahead of “filtered-branch”
press “x” in the branch input and see list of branches again
see the compare tab return to default state

Other pieces:

ahead/behind counts for each branch is in #3968
toggle for behind/ahead or any behind info in #3997

Notes: @donokuda said this may change soon

Before: screen shot 2018-02-08 at 2 11 27 am

(branch list in app for reference) screen shot 2018-02-12 at 11 02 10 pm

After: (default view)

(select branch options)

(selecting branch)

(filtering branch)

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

donokudacommented, Feb 28, 2018

@iAmWillShepherd That’s around changing the tab label from “Changes” to “Commit”

Sorry for the confusion there 😭

1reaction

shiftkeycommented, Feb 27, 2018

Where can I get the icon asset for the branch textbox?

I know this one! It should be this icon which can be rendered as an Octicon React component using the OcticonSymbol.gitBranch symbol.

Top Results From Across the Web

RBB] Compare Branches Feature tracker · Issue #3956 - GitHub

Compare to Branch [RBB] Compare to Branch #3967 - compare my work to any branch and see the commits that are ahead of...

Heart Block Types - BHF - British Heart Foundation

A heart block is an abnormal heart rhythm (arrhythmia). Learn all about the causes, different types, treatments and symptoms for this heart condition....

Right Bundle Branch Block (RBBB) - ECG Library - LITFL.com

Right Bundle Branch Block (RBBB) activation of the right ventricle is delayed as depolarisation spreads across septum from left ventricle.

Right Bundle Branch Block - StatPearls - NCBI Bookshelf

Right bundle branch block (RBB) is an electrocardiogram finding resulting in a widened QRS and electrocardiographic vector changes.

Bundle Branch Blocks - Right & Left, Complete vs Incomplete

A bundle branch block (BBB) is a block of the right or the left bundle branches that propagate depolarizations from the Sino-Atrial node...