Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[stashing] Double clicks of buttons throws error and double log entries

See original GitHub issue

If you click either the Restore or Discard buttons multiple times in row rapidly, you get this.

Restore = error msg Screen Shot 2019-04-12 at 2 51 50 PM

Discard = double logs Screen Shot 2019-04-12 at 2 52 32 PM

As for Clear, should we change to Discard so it’s inline with right-click in the Changes list?

5977a42c21, mac

Issue Analytics

State:
Created 4 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

shiftkeycommented, May 30, 2019

I was able to reproduce this on Windows with an external mouse and using Restore (with 3 files stashed) instead of Discard:

The impact seems to be minimal (the first git stash pop appears to complete successfully) but I think the app could handle this case better (disable the button while the restore is happening?)

1reaction

iAmWillShepherdcommented, Jun 3, 2019

The impact seems to be minimal (the first git stash pop appears to complete successfully) but I think the app could handle this case better (disable the button while the restore is happening?)

I agree that we should be disabling the button while the restore is working. We do this in other places in the UI, so doing what you suggest would ensure we are being consistent.