Surfacing auth error for Enterprise sign-in post oAuth

Initial Desktop sign-up process: After using the sign-in with the browser link for Enterprise, I was unable to login (as I expected in my testing), however, I never was shown our generic auth error following the browser’s oauth process redirect back to Desktop.

I purposefully added www to the URL, and used http instead of https to trigger the error. The console caught the 404 requestOAuthToken: failed with endpoint error but the user should also be notified with our generic messaging.

Reproduce:

• Revert Desktop to initial setup
• Select Enterprise sign via browser
• Manipulate the URL (I added www and used non-SSL)
• Oauth should open in browser and redirect back to Desktop
• No error surfaced to user

However, repeating the same process from the Preferences modal, results in a surfaced error as intended:

Perhaps we could mirror this error in the sign-up process? (Side note: if we show “continue with the browser” button in above modal, it just creates a loop for the user. Only option should be to cancel.)

mac os x, 1.0.12-beta1

[iAmWillShepherd]

@shiftkey, I’ve moved this to milestone 1.2.x so we can close out 1.1.x.

[billygriffin]

I think we ought to let this one surface organically. Closing for now.