question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

compilation errors with TypeScript 4.3 and noImplicitOverride

See original GitHub issue

TS 4.3 adds a noImplicitOverride compilation flag, and all methods that override a parent method are required to be marked with override.

@krzkaczor how should we handle this? Add a switch or detect TS version and include the override modifiers? I don’t think there is an option to disable noImplicitOverride selectively for the typechain-generated directories 😦

Other ideas seem very ugly since they effectively disable typechecking:

  • // @ts-nocheck at the top of the file
  • // @ts-ignore at each meathod

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
krzkaczorcommented, Nov 14, 2021
0reactions
krzkaczorcommented, Nov 26, 2021

Yeah right. This was not implemented at all. Releated: https://github.com/dethcrypto/TypeChain/issues/546

Read more comments on GitHub >

github_iconTop Results From Across the Web

TypeScript analysis fails to complete with compiler option ...
Hello, I got an issue with SonarScanner where adding the compiler option “noImplicitOverride” breaks the analysis partly.
Read more >
Support TS 4.3 noImplicitOverride compiler flag #139 - GitHub
Regarding noImplicitOverride : I presume the generated code produces errors on TypeScript 4.3 if the flag is on? That would have to be...
Read more >
Documentation - TypeScript 4.3
When this option is turned on, it becomes an error to override any method from a superclass unless you explicitly use an override...
Read more >
override and noImplicitOverride for TypeScript class inheritance
In this # TypeScript #tutorial we look at an exciting new feature in TypeScript 4.3. 6 years in the making its finally landed....
Read more >
Announcing TypeScript 4.3 - Microsoft Developer Blogs
Tools like the TypeScript compiler can just erase TypeScript ... TypeScript would error under --noImplicitOverride , and give us a clue that ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found