Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ethers] Function fragments with struct arrays are falsely represented as `tuple[]`

See original GitHub issue

Typechain generates these function fragments:

  functions: {
    "requestExec(address,bytes,uint64,uint256,uint256,tuple[])": FunctionFragment;
    "requestExecWithTimeout(address,bytes,uint64,uint256,uint256,tuple[],uint256)": FunctionFragment;
  };

However when outputting the actual function fragments you will see that the fragment keys do not align. This is because typechain represents a (address,uint256)[] tuple-array as just tuple[].

{

  'requestExec(address,bytes,uint64,uint256,uint256,(address,uint256)[])': FunctionFragment {
    type: 'function',
    name: 'requestExec',
    constant: false,
    inputs: [
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType]
    ],
    outputs: [ [ParamType] ],
    payable: false,
    stateMutability: 'nonpayable',
    gas: BigNumber { _hex: '0xaeb690', _isBigNumber: true },
    _isFragment: true
  },
  'requestExecWithTimeout(address,bytes,uint64,uint256,uint256,(address,uint256)[],uint256)': FunctionFragment {
    type: 'function',
    name: 'requestExecWithTimeout',
    constant: false,
    inputs: [
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType],
      [ParamType]
    ],
    outputs: [ [ParamType] ],
    payable: false,
    stateMutability: 'nonpayable',
    gas: BigNumber { _hex: '0xaeb690', _isBigNumber: true },
    _isFragment: true
  },
}

Issue Analytics

State:
Created 2 years ago
Reactions:1
Comments:7 (4 by maintainers)

Top GitHub Comments

1reaction

krzkaczorcommented, May 30, 2021

@TransmissionsDev tbh I am swamped with work. It would be super useful if you could create a PR for this.

1reaction

krzkaczorcommented, May 24, 2021

@TransmissionsDev thanks for this issue. Interesting bug. It might be a problem in out abi parser but not sure. Can you create a minimal repro somewhere? or just post here a solidity code that would generate such ABI?