Redundant cc code in email.py?

Describe the bug I’m doing some work on helpdesk/email.py for a fork of Helpdesk. I noticed that the work done in lines 507-516 don’t seem to have any effect, and when run, the block doesn’t parse the emails from message.get_all('cc', None) properly in one case.

The block seems to be leftover from some rework commits, since the variable cc isn’t used elsewhere; later on, the line 360 creates a list of addresses correctly and in fewer lines.

Is there a reason for this code block to be here? Or can I remove it without issue?

To Reproduce Here’s a reproduction based on one email I imported. For this email, on line 507, message.get_all('cc', None) produces this list of length 1 (I’ve randomized the names/domain):

[
    '"Brunet, Angelus (ABC)" <[e-mail]>, "Durant, Lawrence ABC)"\r\n\t<[e-mail]>, "Abrami, Henri (ABC)" <[e-mail]>, \r\n\t"Barta, Kai (ABC)" <[e-mail]>'
]

Using that value for cc, and replacing line 510’s message.get_charset() with None, the final result on line 516 splits on the commas inside the names, and it doesn’t strip \r\n\t from one of the strings.

{
    '"Barta',
    'Kai (ABC)" <[e-mail]>',
    '"Durant', 
    'Angelus (ABC)" <[e-mail]>',
    '"Abrami',
    'Henri (ABC)" <[e-mail]>',
    '"Brunet',
    'Lawrence ABC)"\r\n\t<[e-mail]>'
}

Expected behavior I would expect the block to instead produce the following:

{
    '"Barta, Kai (ABC)" <[e-mail]>', 
    '"Brunet, Angelus (ABC)" <[e-mail]>', 
    '"Abrami, Henri (ABC)" <[e-mail]>',
    '"Durant, Lawrence (ABC)" <[e-mail]>'
}

Additional context My fork of email.py is up to date with the latest commit in the master branch. I’m debugging email.py locally, by running ./manage.py get_email with a real email address using IMAP.

[ebeers-png]

Thanks, I’ll take it out of my fork then!

I’ll try to submit a PR after I finish working on the file! I’ve cleaned up some other little importing bugs for my fork that I’m sure would be useful to the master branch 😃

[gwasser]

This was cleaned up for our next release (0.5), check out the unstable branch.