getting timeout after streaming logs for some time

This is very likely an engine issue, first I would like to open here.

It looks like there is a change in behavior. When streaming logs with 1.10 I get timeout:

Traceback (most recent call last):
  File "/usr/lib64/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
  File "/usr/lib64/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
  File "/home/tt/g/sen/sen/tui/widgets/list/common.py", line 43, in fetch_logs
    for line in generator:
  File "/home/tt/.local/lib/python3.5/site-packages/docker/client.py", line 279, in _stream_raw_result
    for out in response.iter_content(chunk_size=1, decode_unicode=True):
  File "/usr/lib/python3.5/site-packages/requests/utils.py", line 363, in stream_decode_response_unicode
    for chunk in iterator:
  File "/usr/lib/python3.5/site-packages/requests/models.py", line 667, in generate
    raise ConnectionError(e)
requests.exceptions.ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Read timed out.

generator is client.logs(c, stream=True)

This repro should be sufficient: https://github.com/docker/docker-py/issues/919#issuecomment-181795059

I know this also happens when using compose.

[zultron]

On a detached container, for l in container.logs(stream=True, follow=True): print(l) times out after a while with the following traceback:

  File "/usr/local/lib/python2.7/dist-packages/docker/types/daemon.py", line 32, in __next__
    return next(self._stream)
  File "/usr/local/lib/python2.7/dist-packages/docker/api/client.py", line 396, in _stream_raw_result
    for out in response.iter_content(chunk_size, decode):
  File "/usr/local/lib/python2.7/dist-packages/requests/utils.py", line 500, in stream_decode_response_unicode
    for item in iterator:
  File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 757, in generate
    raise ConnectionError(e)
requests.exceptions.ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Read timed out.

This happens when the container has no console output for long enough to exceed the timeout. A couple of workarounds helped:

• Disable the timeout with client = docker.from_env(timeout=None) (None means no timeout to urllib3)
• Set up a ‘heartbeat’ to periodically print to the console

This sounds like the issue @TomasTomecek. It also makes sense that @jasonamyers and @akki might hit this with other parts of the API that can possibly wait a long time for the server to respond.

While I’m not familiar with the code, ideally, these methods would set an infinite timeout, while other methods would set a reasonable default timeout.

[zultron]

Indeed you did; I missed the pingback from #1959.

That patch works for me in place of the workarounds in my previous comment.

+1