logs() hangs after container has quit

Hi,

I’m using version 1.6 of docker-py on Python 3.4.3+ on Ubuntu 15.10

bash# pip3 freeze | grep docker-py && python3 --version && docker version
docker-py==1.6.0
Python 3.4.3+
Client:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.3
 Git commit:   a34a1d5
 Built:        Fri Nov 20 17:56:04 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.9.1
 API version:  1.21
 Go version:   go1.4.2
 Git commit:   a34a1d5
 Built:        Fri Nov 20 13:20:08 UTC 2015
 OS/Arch:      linux/amd64

This hangs after my container finishes what it’s doing:

 machine.start(container=backup)
 for line in machine.logs(container=backup, stream=True):
   log(line.decode("utf-8").strip(), name)

I don’t want to have to return to wrapping shell commands, uggg 😦

I have seen various closed issues related to this. Am I missing some subtlety in the docs or is this a problem again?

Thanks!

[tedmiston]

I am still seeing this issue with the latest version of the Docker client (2.5.1). Using tty=True plus the streaming fix by @darkermatter in https://github.com/docker/docker-py/issues/919#issuecomment-181815005 fixed it for us.

[ghost]

Thanks Tomas,

I now have this working on Docker Engine 1.9.1 (I’ll test 1.10.0 later). As your code comment mentioned, stream is spitting out every character without buffering.

 machine.start(container=backup)
 line = ''
 for char in machine.logs(container=backup, stream=True):
     if char == '\n':
         log(line, name)
         line = ''
     else:
         line = line + char