Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Link for non-DockerHub tools is incorrect

See original GitHub issue

Describe the bug If a workflow references a non-DockerHub Docker image, the link incorrectly has hub.docker.com as the domain.

To Reproduce Steps to reproduce the behavior:

curl -s 'https://dockstore.org/api/workflows/5874/tools/13615' -H 'Accept: application/json' | jq '.'
[
  {
    "id": "icgc_pcawg_dkfz_workflow",
    "file": "dkfz/icgc_pcawg_dkfz_sbg.cwl",
    "docker": "images.sbgenomics.com/bogdang/pcawg-dkfz:1.0",
    "link": "https://hub.docker.com/_/images.sbgenomics.com/bogdang/pcawg-dkfz"
  },
  {
    "id": "pcawg_icgc_delly_workflow_1",
    "file": "delly/icgc_pcawg_seqware_delly_sbg.cwl",
    "docker": "images.sbgenomics.com/bogdang/pcawg-delly:10072019",
    "link": "https://hub.docker.com/_/images.sbgenomics.com/bogdang/pcawg-delly"
  }
]

Note how the links are to DockerHub, even though the images are hosted on SB.

Visible in the UI by navigating to https://dockstore.org/workflows/github.com/sbg/sbg_dockstore_tools/icgc_pcawg_dkfz_embl_sbg_modified:master?tab=tools

Expected behavior Links should be to SB Docker image repository.

Additional context Happens on prod and dev. Dev info:

Webservice - 2589683

UI - 2.6.1-42-g3b3889cf

Compose Setup - 8c083bddfa2e8cfcb517792d45b03b95dc3dda5d

Deploy - 1.9.2-24-g3fa31af

┆Issue is synchronized with this Jira Story ┆Fix Versions: Dockstore 1.9.X ┆Issue Number: DOCK-1588 ┆Sprint: Sprint 45- Trumpetfish ┆Issue Type: Story

Issue Analytics

State:
Created 3 years ago
Comments:6 (5 by maintainers)

Top GitHub Comments

1reaction

NatalieEOcommented, Oct 6, 2020

Current logic for making the link doesn’t yet support non-DockerHub/Quay entries (the code just reaches the last else clause): https://github.com/dockstore/dockstore/blob/96424cf3dc0f7ca623efc17670613db659242b55/dockstore-webservice/src/main/java/io/dockstore/webservice/languages/LanguageHandlerInterface.java#L361

A simple solution for now could be to check if the entry looks like a URL with regex?

Didn’t do much with it, but wrote some code that tries to detect the other image registries we support as an FYI https://github.com/dockstore/dockstore/blob/96424cf3dc0f7ca623efc17670613db659242b55/dockstore-webservice/src/main/java/io/dockstore/webservice/languages/LanguageHandlerInterface.java#L373

0reactions

coverbeckcommented, Oct 20, 2020

Going to close. We can revisit link discussion if it comes up from a user, otherwise, I think it’s good for now.

Top Results From Across the Web

docker - Official Image - Docker Hub

Although running Docker inside Docker is generally not recommended, there are some legitimate use cases, such as development of Docker itself. Docker is...

Docker Hub and Docker Registries Beginner's Guide - JFrog

A practical step-by-step guide to set up and use Docker Hub, Docker's official and default container registry.

Troubleshooting errors with Docker commands when using ...

In some cases, running a Docker command against Amazon ECR may result in an error message. Some common error messages and potential solutions...

What's Wrong With The Docker :latest Tag? - vsupalov.com

Frequent issues and misconceptions around Docker's most used image tag. ... There's no tool which will make it pleasant to deploy a “new...

Docker Tools Tips and Tricks - Visual Studio Code

Invalid URL errors ... If you have a need to connect to a remote Docker daemon, we recommend using Docker contexts instead of...