Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

getProductInfo and picsCacheAll optimization

See original GitHub issue

As I see it, when picsCacheAll is enabled, every pics update event, the app or sub gets its product info requested and cached. Thus, cached data should always be up-to-date. So, I suggest you return cached data when getProductInfo is called and picsCacheAll is enabled.

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

DoctorMcKaycommented, Jul 28, 2018

How will caches go out of sync? If pics update fails, you could delete the outdated data to prevent having outdated data.

Things happen, especially when Valve is installed.

Perhaps you could add a boolean to force fresh getProductInfo.

I hate boolean parameters, and in this case it’s not necessary since if you want to check the cache, you could just check the cache.

At least, add to documentation, you could use cached picsCache data instead of getProductInfo if picsCacheAll is enabled.

Okay, I’ll do that.

0reactions

Revadikecommented, Jul 27, 2018

At least, add to documentation, you could use cached picsCache data instead of getProductInfo if picsCacheAll is enabled.

Top Results From Across the Web

Untitled

These access tokens can be used with getProductInfo. ... Optimized input box limits 3. ... If picsCacheAll is enabled, enablePicsCache is enabled, ...