Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

'tradeOffers' event not fired reliably

See original GitHub issue

Commit 2672916d7ea0a037068e6a45d1b729f96450a0ec is causing the tradeOffers event to not fire if the user received a new trade offer after handling an old one, since the amount of incoming trade offers didn’t change.

Is this intended behaviour?
Should I update the _lastTradeOfferCount property manually after handling an incoming trade offer?
What was the reason behind implementing the check in the first place?

Thanks!

Issue Analytics

State:
Created 6 years ago
Comments:7 (4 by maintainers)

Top GitHub Comments

2reactions

DoctorMcKaycommented, Mar 7, 2018

This is fixed in v3.25.2.

0reactions

florianmrzcommented, Mar 7, 2018

Alright, thanks a lot for looking into it!

Top Results From Across the Web

Why isn't dispatchEvent firing? - Stack Overflow

First, the event that you are dispatching is not a bubbling Event . ... Then your event handler, since it is a child,...

bukson/steampy: A Steam trading library for python 3 - GitHub

steampy is a library for Python, inspired by node-steam-tradeoffers, node-steam and other libraries for Node.js. It was designed as a simple lightweight ...

Final Rule: Selective Disclosure and Insider Trading - SEC.gov

The requirement to make prompt disclosure is triggered when a senior official of the issuer learns that there has been a non-intentional disclosure...

Issue linkage and international cooperation - JSTOR

However, Hafner-Burton's study evaluates the impact of issue linkage on inducing certain behavior by a government within its state, not inducing cooperation.

The Puzzle of WTO Safeguards and Regional Trade ...

This reasoning is relevant when the injury determination is based on the totality of imports (in that event, even those imports not causing...