Failing tests don't fail build when warningsAsErrors is false
See original GitHub issueWe’ve started setting warningsAsErrors to false in our builds of Arcade projects because that’s what we did before, and we have some warnings that would currently cause us to start failing, but when we do this test failures don’t fail the build because they’re only logged as warnings. I suspect this is caused by this line, where LogStandardErrorAsError="false"
. I’ve noticed that that’s set that way in a couple different Exec’s, so possibly this is not the only area affected.
Repro:
- Clone git@github.com:aspnet/Extensions.git
- git checkout rybrande/Arcade
- .\build.cmd
That takes a while to run, but if I’m right it should replicated against any arcade repo with a failing test against which warnaserrors=false was passed.
Issue Analytics
- State:
- Created 5 years ago
- Comments:8 (8 by maintainers)
Top Results From Across the Web
Warnings from the build step causes the action to fail even ...
Most CI servers set it automatically. Failed to compile." My project is producing warnings in the build step and this causes the action...
Read more >warnaserror not failing the build with exit 1 if only errors ...
If I build with "Enable system diagnostics" checked, then the build fails, the exit code is 1, and the pipeline step fails. If...
Read more >How not to treat warnings as errors with Travis for React
Failed to compile. I tried to modify the .travis.yml file and add the rule warnings_are_errors: false as indicated in this other post, but...
Read more >C# Compiler Options to report errors and warnings
C# Compiler Options for errors and warnings. These options suppress or enable warnings, and control warnings as errors.
Read more >Warnings as errors and tests
To enable warnings as errors, all we need to do is to call mix compile --warnings-as-errors explicitly: (remember to use the right MIX_ENV...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Yeah, seems like a bug in msbuild to me.
Next step is to find and reference the tracking msbuild bug (assuming there is one)