question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Failing tests don't fail build when warningsAsErrors is false

See original GitHub issue

We’ve started setting warningsAsErrors to false in our builds of Arcade projects because that’s what we did before, and we have some warnings that would currently cause us to start failing, but when we do this test failures don’t fail the build because they’re only logged as warnings. I suspect this is caused by this line, where LogStandardErrorAsError="false". I’ve noticed that that’s set that way in a couple different Exec’s, so possibly this is not the only area affected.

Repro:

  1. Clone git@github.com:aspnet/Extensions.git
  2. git checkout rybrande/Arcade
  3. .\build.cmd

That takes a while to run, but if I’m right it should replicated against any arcade repo with a failing test against which warnaserrors=false was passed.

Issue Analytics

  • State:open
  • Created 5 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
tmatcommented, Dec 16, 2018

Yeah, seems like a bug in msbuild to me.

0reactions
markwilkiecommented, Jan 9, 2019

Next step is to find and reference the tracking msbuild bug (assuming there is one)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Warnings from the build step causes the action to fail even ...
Most CI servers set it automatically. Failed to compile." My project is producing warnings in the build step and this causes the action...
Read more >
warnaserror not failing the build with exit 1 if only errors ...
If I build with "Enable system diagnostics" checked, then the build fails, the exit code is 1, and the pipeline step fails. If...
Read more >
How not to treat warnings as errors with Travis for React
Failed to compile. I tried to modify the .travis.yml file and add the rule warnings_are_errors: false as indicated in this other post, but...
Read more >
C# Compiler Options to report errors and warnings
C# Compiler Options for errors and warnings. These options suppress or enable warnings, and control warnings as errors.
Read more >
Warnings as errors and tests
To enable warnings as errors, all we need to do is to call mix compile --warnings-as-errors explicitly: (remember to use the right MIX_ENV...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found