Signing ARM/ARM64 crossgened images broken
See original GitHub issueSigning ARM or ARM64 crossgened images fails because the images are incorrectly identified as regular managed assemblies and the SignTool task tries (and fails) to StrongName sign them.
This is most likely due to the ContentUtil.GetAssemblyName
method, which uses AssemblyName.GetAssemblyName
to detect whether an assembly is managed. AssemblyName.GetAssemblyName
throws for x86 and x64 crossgened images, but returns a value for ARM images
https://github.com/dotnet/arcade/blob/d7e189c6182ec601a086e70ba5a88f1b837f12c3/src/Microsoft.DotNet.SignTool/src/ContentUtil.cs#L64
Issue Analytics
- State:
- Created 5 years ago
- Comments:40 (32 by maintainers)
Top Results From Across the Web
Solved: Broken Images After Uploading - Canvas Community
Solved: Some of the images I am uploading show up as broken and do not display. I have tried multiple work arounds like...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
We define default strong name and authenticode certicicates here: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.proj#L20-L25
So I assume one of them kicks in for System.Private.CoreLib.
I think it would be useful if the SignTool detected crossgen’d images and skipped strong name signing automatically.
Waiting for code review of https://github.com/dotnet/arcade/pull/2079. I pinged @tmat yesterday but he’s a busy guy and I don’t believe that anyone is blocked on this at the moment.