Pdbs are overwritten when publishing in multi-framework-targeted build

I’m in the process of trying to verify that the winforms-designer symbols have published correctly to symweb, and we have one dll that is failing while all the others are passing. While investigating this, Dustin mentioned that some of our dlls are multi-targeted (they build against both .net framework 4.7.2 AND .net core 3.0).

The problem I’m seeing is the pdb’s are published into a single build artifact called “PdbArtifacts”, which is flattened.

https://dnceng.visualstudio.com/internal/_build/results?buildId=404832&view=results

So which WinformsSurface.Core.pdb is there?

Upload 'F:\workspace.1\_work\1\s\artifacts\SymStore\Release\WinFormsSurface.Core\net472\WinFormsSurface.Core.pdb' to file container: '#/2685471/PdbArtifacts'
Associated artifact 5225542 with build 404832
##[section]Async Command End: Upload Artifact
##[section]Async Command Start: Upload Artifact
Uploading 1 files
File upload succeed.
Upload 'F:\workspace.1\_work\1\s\artifacts\SymStore\Release\WinFormsSurface.Core\netcoreapp3.0\WinFormsSurface.Core.pdb' to file container: '#/2685471/PdbArtifacts'
Associated artifact 5225542 with build 404832
##[section]Async Command End: Upload Artifact
##[section]Async Command Start: Upload Artifact
Uploading 1 files
File upload succeed.

Maybe these uploads are async, and this is a race condition. Or maybe the second upload always wins. In either case, we’re losing a pdb here, since one is stomping over the other. So when we try to upload symbols, we’re not sending everything, and symcheck fails when we try to verify.

So what probably needs to happen here is some sub dirs, one for each framework moniker, which is available in the output above. That would make sure stuff doesn’t get overwritten.

[tmat]

That’s indeed incorrect. The converted PDBs that are to be published to symbol server are stored in a directory structure under artifacts/SymStore that includes the TFM. The problem is likely in the logic that copies these files to the artifacts.

@JohnTortugo

[riarenas]

@JohnTortugo https://github.com/dotnet/arcade/pull/4284#issuecomment-550134655 seems to be the explanation for why the dlls are there.