Remove PrivateAssets="All" for EF Core. Design dependency in MS.VS.Web.CG.EFCore package

Making the Microsoft.EntityFrameworkCore.Design package a private dependency has an unfortunate side effect: https://github.com/aspnet/Scaffolding/blob/dev/src/VS.Web.CG.EFCore/VS.Web.CG.EFCore.csproj#L20

Scaffolding fails if the user project has a lower version of Microsoft.EntityFrameworkCore.Design than what was used to build the scaffolding packages.

In the below csproj, Microsoft.AspNetCore.All package has Microsoft.EntityFrameworkCore.Design at version 2.0.1 whereas Microsoft.VisualStudio.Web.CodeGeneration.Design was built with version 2.0.2

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.5" />
    <PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="2.0.3"  />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.2" />
  </ItemGroup>
</Project>

The user would see an error while scaffolding:

Could not load file or assembly 'Microsoft.EntityFrameworkCore, Version=2.0.2.0, Culture=neutral, PublicKeyToken=...'. The located assembly's manifest definition does not match the assembly reference.

The workaround for the user would be to update the Microsoft.AspNetCore.All package to the latest 2.0.x version.

cc @seancpeters @vijayrkn

[vijayrkn]

I have cleared the milestone.

@Eilon - We will triage this in the next Scaffolding triage.

[vijayrkn]

Since 3.0 version does not support .NET Framework, this is not an issue any more. Closing.