Review how identity scaffolder updates the layout to add the login partial

Currently the identity scaffolder updates the app layout with the following code to add the login partial:

            <div class="navbar-collapse collapse">
                @{
                    var result = Engine.FindView(ViewContext, "_LoginPartial", isMainPage: false);
                }
                @if (result.Success)
                {
                    await Html.RenderPartialAsync("_LoginPartial");
                }
                else
                {
                    throw new InvalidOperationException("The default Identity UI layout requires a partial view '_LoginPartial' " +
                        "usually located at '/Pages/_LoginPartial' or at '/Views/Shared/_LoginPartial' to work. Based on your configuration " +
                        $"we have looked at it in the following locations: {System.Environment.NewLine}{string.Join(System.Environment.NewLine, result.SearchedLocations)}.");
                }
            </div>

We should review this code and make share it is appropriate for all layouts.

[phantom2017-Nov]

It is 2018, and you decided to hard code a reference to a “_LoginPartial” in your code ! Wow! Why do you keep changing things that are working, especially if you can’t give a seamless upgrade … This is wasting time to figure out where the reference to this file is & how to get rid of it - if at all possible. Further, it seems to generate its own templated page … who asked for all of this brilliancy from your side ? (The assumption seems to be that there is always a “Layout” page – why has this assumption been made (regardless of “best” practices) ?

[Rick-Anderson]

Close it. We get alot of traffic and comments on that topic. That page gets 18.5 PV/month.