Annotations for cases the analyzer can't figure out.

public interface IWithAnnotations
{
    [return: MustDispose]
    IDisposable Create();

    bool TryCreate([MustDispose]out IDisposable disposable);

    [return: DoNotDispose]
    IDisposable GetOrCreate();

    bool TryGet([DoNotDispose]out IDisposable disposable);

    void Add([TransferOwnership] IDisposable disposable);
}

Not sure what attributes are needed and how we should word things. Also should probably not require a dependency on a nuget with attributes. Does JetBrains.Annotations have something for this?

[JohanLarsson]

Made a PR with draft names, please review & comment.

[jeremyVignelles]

I didn’t read the full conversation yet. There are cases where you don’t have interfaces. I’d say “Don’t specify what should be done with the Disposable in an override”. This rule applies to interface implementations, abstract method overrides as well as virtual overrides. (does it apply to new methods?) This doesn’t mean you can’t put an annotation on the constructor or in a specific method