Require GC.SuppressFinalize(this) when virtual dispose?

public abstract class C : IDisposable
{
    public void Dispose()
    {
        this.Dispose(true);
        // Require GC.SuppressFinalize(this); here?
    }

    protected virtual void Dispose(bool disposing)
    {
        ...
    }
}

[sharwell]

In the current Dispose pattern, the call to SuppressFinalize is required if you have a virtual Dispose method and the containing type (C in this case). It does not matter whether a user-defined finalizer is present.

The rule is not optional in this pattern so you do not need a configuration option to disable it. New guidance for IDisposable which removes this requirement as part of a broad simplification is in progress but not yet approved as a recommendation.

[JohanLarsson]

We keep it as default warning for now then.