DSpaceApiExceptionControllerAdvice logs nothing of interest

Describe the bug Method sendErrorResponse is also responsible for logging the exception, but except in a few specific cases it logs only the HTTP response code, without mentioning the actual exception or location.

In the few specific cases we get a stack trace. As stated in comments, we probably don’t want that level of detail for most exceptions, but I think that we do want to know what happened and where – why are we sending this non-success response?

To Reproduce Steps to reproduce the behavior:

1. Trigger a 404 response.
2. See the log. All you’ll find is “org.dspace.app.rest.exception.DSpaceApiExceptionControllerAdvice @ An exception has occurred (status:404)”.

Expected behavior When logging an exception, we should always log the actual exception and its location.

[mwoodiupui]

I ran into a specific case today. A user reported incorrect behavior, but the log gives no help in tracking down the problem. I’ve written a patch which just adds the exception’s own message and location to the single line log entry. I agree that we don’t want a stack trace for every 404.

[mwoodiupui]

There is already a set LOG_AS_ERROR containing the single status 422. This could be filled from configuration instead of a static assignment. Members of LOG_AS_ERROR get a stack trace. All 500-class statuses are already treated this way.