"metadata-export" script should NOT allow file location to be specified via REST API /scripts endpoint
See original GitHub issueCreated based on feedback in https://github.com/DSpace/dspace-angular/pull/636#pullrequestreview-441228120
Currently, in the Scripts & Processes UI, any administrator can specify a --file
location, for the metadata-export
script. Since that script is only able to write a file to the server where DSpace is running, it’s unlikely the Admin will know an exact path to type in. Additionally, this could be a security issue if you can write the output file anywhere on the system. Ideally, instead, the file should always be written to the [dspace]/exports/
folder (which is where it was written in DSpace 6.x, IIRC).
Ideally, the REST API should NOT allow a --file
parameter to be passed in. Instead, it should automatically create a new file in the [dspace]/exports
/ folder at all times. Therefore, the user should not be able to specify this location, however they can download the file once the export completes.
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (4 by maintainers)
Top GitHub Comments
we estimate the work to be around 3 hours
@tdonohue I opened up a new PR for this issue that follows the suggestion you made: https://github.com/DSpace/DSpace/pull/2924