question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Build of che-theia is broken

See original GitHub issue

Describe the bug

It looks like after merging this commit to Theia master, we cannot properly build che-theia.

In fact, yarn command finishes without errors, but after navigating to examples/assembly directory it turns out that the assembly is non built.

Only after running yarn run prepare @eclipse-che/theia-assembly in Theia root we can see that it’s impossible to build package at all.

Steps to reproduce

  • clone theia sources
  • init che-theia by running che:theia init
  • builtd by yarn

Expected behavior

The directory examples/assembly must have built che-theia.

Runtime

  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)

Screenshots

Screenshot from 2020-01-28 14-51-14

Screenshot from 2020-01-28 14-52-22

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

2reactions
benoitfcommented, Jan 30, 2020

@RomanNikitenko yes, upstream theia is using typescript build mode. For building the image there is no ‘gain’ as we always start from scratch. But in development mode, it’s keeping a cache with incremental mode so it’s faster.

I added (added by che-theia generator) in the example/assembly a tsconfig json file which references all tsconfig.json of eclipse che theia packages. Note that the order is important for now as it’s how the compiler will do the graph. To enhance that, we should reference in each tsconfig.json file the dependencies through their tsconfig.json (we could reuse the @dependencies/devDependencies and generate that as well automatically)

Then, the root config [1] is now including as well a link to the tsconfig.json of example/assembly (modified again by the generator)

Some libraries have been updated upstream but I had to stick to an older version of mkdirp as ci.codenvycorp used to validate PR is using nodejs 8 (!!!) while new versions of mkdirp are requiring nodejs >= 10

[1] : https://github.com/eclipse-theia/theia/blob/master/configs/root-compilation.tsconfig.json

1reaction
RomanNikitenkocommented, Jan 30, 2020

@benoitf Yesterday I investigated how it works by adding compile.tsconfig.json files with the corresponding references as I commented here. But I tried it not on building images step, but using che-in-che, just to understand how it works. Today I can see your response, the changes for generator and dockerfile, it extends my knowledge and experience about it.

thank you very much for the detailed response!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Che Theia build is broken · Issue #14618 · eclipse/che - GitHub
After changes in upstream Eclipse Theia project build of Che Theia is broken. From CI build log: lerna ERR!
Read more >
How to build Che Theia image with my own changes?
The sources of eclipse/che-theia is located here. After the changes are made, you need to rebuild the image with the following command: ...
Read more >
Chapter 2. Che-Theia IDE basics - Red Hat Customer Portal
2.1. Defining custom commands for Che-Theia ; CodeReady Workspaces commands. theia:build. The exec type implies that the CodeReady Workspaces runner is used for ......
Read more >
Che-Theia workspaces :: Eclipse Che Documentation
Eclipse Che telemetry API allows tracking: Duration of a workspace utilization. User-driven actions such as file editing, committing, and pushing to remote ...
Read more >
Eclipse Che vs. VS Code (online|codespaces) - EclipseSource
This means you can install VS Code extensions in Che Theia. ... There are currently three ways to create such as codespace:.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found