Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor `Ide.waitWorkspaceAndIde` method removing unused arguments

See original GitHub issue

Is your enhancement related to a problem? Please describe.

It is not a problem, but it’s cleaning up of code that influences all the tests that use this method

Describe the solution you’d like

In pageobjects/ide/Ide.ts method waitWorkspaceAndIde still contains two arguments which have been previously used for creating a locator for workspace status indentificator in the left panel of Che

Screenshot_20200127_170524

The method was removed, but the arguments it used remained behind.

I would like to go through the classes and tests and remove those unused variables.

Issue Analytics

State:
Created 4 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

Ohrimenko1988commented, Jan 28, 2020

According to the history https://github.com/eclipse/che/blob/master/tests/e2e/pageobjects/ide/PreviewWidget.ts#L44-L59 looks like that method logic has been changed and variables became unnecessary but were not deleted. If you don’t mind it would be great in the frame of this issue add to the tslint configuration a rule about unused arguments. Here is an explanation with example: https://palantir.github.io/tslint/rules/no-unused-variable/

0reactions

che-botcommented, Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.