Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Clean up che-theia build: rely on multistage build as much as possible.

See original GitHub issue

Is your task related to a problem? Please describe.

I tried to build che-theia from my local laptop but failed :

Missing yarn command
At the moment, yarn installation was broken on Fedora
Missing g++

We are already doing most of the build in docker multistage builld, so I don’t see any reason to keep this line: https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16

Describe the solution you’d like

Remove the line https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16 And make sure everything is done and still working in existing multistage build.

Describe alternatives you’ve considered

N/A

Additional context

Selection_198

Selection_196

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

sunixcommented, Feb 4, 2021

If we download the dependencies in the che-theia-dev build, it would benefit dogfooding UX: it won’t redownload the dependencies each time you create a new workspace.

0reactions

che-botcommented, Mar 19, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.