Clean up che-theia build: rely on multistage build as much as possible.
See original GitHub issueIs your task related to a problem? Please describe.
I tried to build che-theia from my local laptop but failed :
- Missing
yarn
command - At the moment, yarn installation was broken on Fedora
- Missing
g++
We are already doing most of the build in docker multistage builld, so I don’t see any reason to keep this line: https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16
Describe the solution you’d like
Remove the line https://github.com/eclipse/che-theia/blob/39b67042da45484b53af20ad1759ddaeaf19762c/build.sh#L16 And make sure everything is done and still working in existing multistage build.
Describe alternatives you’ve considered
N/A
Additional context
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Plugins Sprint 198 · Issue #19159 · eclipse/che - GitHub
Clean up che-theia build : rely on multistage build as much as possible. Clean up che-theia build: rely on multistage build as much...
Read more >Do we need to clean-up in a multi-stage build? - Stack Overflow
1 Answer 1 ... Cleaning resources from your "helper" is not mandatory, you will not have artifacts from previous stages in your final...
Read more >Multi-stage builds - Docker Documentation
Keeping your images small with multi-stage builds. ... and you need to remember to clean up any artifacts you don't need before moving...
Read more >Clean and maintainable Docker images using multi-stage builds
In this post I'm going to show you how you can keep your Docker images maintainable by making use of multi-staged builds.
Read more >Using Multi-Stage Builds to Simplify And Standardize Build ...
Multi-stage Dockerfile builds can help shift information left and standardize commands in an elegant way.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
If we download the dependencies in the che-theia-dev build, it would benefit dogfooding UX: it won’t redownload the dependencies each time you create a new workspace.
Issues go stale after
180
days of inactivity.lifecycle/stale
issues rot after an additional7
days of inactivity and eventually close.Mark the issue as fresh with
/remove-lifecycle stale
in a new comment.If this issue is safe to close now please do so.
Moderators: Add
lifecycle/frozen
label to avoid stale mode.