Happy path tests are failing on 'Language server validation' step

Describe the bug

Happy path tests are failing on the Language server validation step.

14:06:25   Language server validation
14:09:06     ✓ Java LS initialization (160259ms)
14:10:11     1) Error highlighting
14:10:11   [ERROR] CheReporter runner.on.fail: Language server validation Error highlighting failed after 65388ms
14:10:11 
14:10:11 
14:10:11   4 passing (4m)
14:10:11   1 failing
14:10:11 
14:10:11   1) Language server validation
14:10:11        Error highlighting:
14:10:11      TimeoutError: Exceeded maximum visibility checkings attempts for 'By(xpath, //div[contains(@style, 'top:551px')]//div[contains(@class, 'squiggly-error')])' element, timeouted after 60000
14:10:11       at DriverHelper.waitVisibility (/tmp/e2e/utils/DriverHelper.ts:152:15)
14:10:11       at process._tickCallback (internal/process/next_tick.js:68:7)

Che version

• latest
• nightly
• other: please specify

Steps to reproduce

I checked it on a test PR without any changes: https://github.com/eclipse/che-theia/pull/695#issuecomment-775092583

Expected behavior

The tests are happy.

Runtime

I detected it on PR’s check

[dmytro-ndp]

Should be fixed in https://github.com/eclipse/che/pull/19068

[RomanNikitenko]

It is really strange that it was required 20 seconds wait before typing into the Editor, and that 120 seconds were not enough to highlight error.

@dmytro-ndp As I mentioned above for my current issue it’s pretty critical to have Happy Path tests working. So, I added a delay to Language server validation step. You can see my changes here - actually it’s just one line with the delay 20 seconds:

await driverHelper.getDriver().sleep(20000);

Maybe 20 seconds is too long delay - I don’t know - it’s just a workaround for testing my changes.

Today I rerun the tests 6 times, Language server validation test passed successfully without any exception. You can see it in the corresponding reports:

• https://github.com/eclipse/che-theia/pull/778#issuecomment-780435869
• https://github.com/eclipse/che-theia/pull/778#issuecomment-780459085
• https://github.com/eclipse/che-theia/pull/778#issuecomment-780651105
• https://github.com/eclipse/che-theia/pull/778#issuecomment-780705026
• https://github.com/eclipse/che-theia/pull/778#issuecomment-780759452
• https://github.com/eclipse/che-theia/pull/778#issuecomment-780798661

The tests failed due to another issue: https://github.com/eclipse/che/issues/19085.

120 seconds were not enough to highlight error

Note: my delay is before typing a text, not to highlight error