Devfile generateName only works in factory URLs

Describe the bug

Currently, devfiles with generateName instead of name are handled in a somewhat confusing way. If the user passes the devfile through a factory url (/f?url=<>), the devfile is used to create a workspace with the generated name set as .metadata.name. However, devfiles with the generateName field cannot be pasted into a workspace config, as generateName is not supported there.

Having a feature in the devfile spec that is only valid in some cases is confusing.

Che version

• nightly

Steps to reproduce

1. Start workspace from devfile with generateName field (e.g. https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-maven/devfile.yaml)
2. Check config, see that generateName is gone and instead .metadata.name is set
3. Try pasting devfile contents into workspace config, note validation error.

Expected behavior

The same devfile should be able to be passed to Che through all normal methods.

Additional context

https://github.com/eclipse/che/pull/14243#issuecomment-535911322

[sleshchenko]

When using devfiles from the registry (create-workspace tab), the name seems to be ignored and instead gets something like wksp-xxxx.

It’s because of Dashboard. But when you use chectl workspace:start and use devfile from devfile registry - you’ll get workspace with name <generateName><generatedPart>. Probably reusing generate name instead of generating wksp-xxxx might be a good change for Dashboard as well.

[sleshchenko]

I guess it’s not actual anymore, and I’m sure it must be fixed by https://github.com/eclipse/che-dashboard/pull/22