ImagePullPolicy should be configurable for every container

Is your enhancement related to a problem? Please describe.

When deploying Che some images pull policies can be set easily (i.e. for che-server) but others are not and it’s imagePullPolicy: Always no matter what.

That makes it impossible to start Che or even a workspace when offline. Even if all the images are all available on the local disk.

Describe the solution you’d like

JWT proxy image pull policy should be configurable (in che.properties, helm chart and operator)

With the Helm chart it should be possible (but it’s currently not) to:

• Configure postgres image pull policy
• Configure keycloak image pull policy
• Configure sidecars pull policy
• Configure plugin broker pull policy

With the Operator it should be possible (but it’s currently not) to:

• Configure the nightly operator pull policy when using chectl
• Configure plugin broker and sidecars pull policy (implemented as part of https://github.com/eclipse/che/issues/14635)

[davidwindell]

Awesome, thanks @tolusha - this works and workspace startup time is so much faster with IfNotPresent now, ~10 seconds

[davidfestal]

Let me provide information about the status of this on the Operator side:

With the Operator it should be possible (but it’s currently not) to:

* Configure operator pull policy

This one is a bit special, since its overriding depends on the method of the Che operator installation:

• from OperatorHub: In the OLM CSVs, pull policy is set to IfNotPresent for stable channel (releases), and to Always for the nightly channel.
• from chectl: By default the Always pull policy is used since by default chectl installs the nightly operator. But I assume we could create an issue to allow overriding it in the chectl CLI
• from any deploy.sh script: again, the pull policy could easily be overridden when applying the operator deployment

* Configure che-server pull policy
* Configure plugin registry pull policy
* Configure devfile registry pull policy
* Configure postgres pull policy
* Configure keycloak pull policy

Already available as fields in the custom resource.

* Configure plugin broker pull policy
* Configure sidecars pull policy

This is already possible by setting the appropriate Che server environment variable:

• for now through the custom config map,
• but very soon it will be even easier after issue https://github.com/eclipse/che/issues/14635 is implemented.