question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

TCK does not work with MP Metrics 5.0

See original GitHub issue

MP Metrics 5.0 is bringing in breaking changes which require changes in the Fault Tolerance TCK.

The ones that I think affect the Fault Tolerance TCK are:

  • @RegistryType is removed, replaced with @RegistryScope
    • @RegistryScope is not a qualifier which means we can’t look it up with CDI.current().select()
    • The only way to get hold of the MetricsRegistry for the base scope is to inject it into a bean with the @RegistryScope annotation
  • Some methods have been removed from Snapshot, particularly getValues() and getMedian()
    • The median can likely be obtained from the new getPercentileValues() array
    • There’s no replacement for getValues() - several of our tests used this to assert that the correct data had been added to the histogram
  • Gauge<T> has been changed to Gauge<T extends Number> which breaks binary compatibility because it changes the signatures of methods which return T

I don’t think there are any changes needed to the spec or API to accomodate MP Metrics 5.0, just to the TCK.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:12 (12 by maintainers)

github_iconTop GitHub Comments

1reaction
Azqueltcommented, Sep 30, 2022

But I think we’re saying the same thing, it would be better if they made it a qualifier, made scope non-binding and used getQualifiers() to find the annotation. Firstly because it is acting as a qualifier so having it be one makes sense and secondly it would make it possible to look up using CDI.current().select().

0reactions
Azqueltcommented, Oct 10, 2022

TCK update to add compatibility with Metrics 5.0 released as 4.0.2

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add `io.openliberty.microprofile.metrics.internal.5.0_fat_tck` · Issue ...
This was omitted currently as we still need an official MP Metrics release which includes a change to allow the TCK to run...
Read more >
eclipse/microprofile-metrics - Gitter
@OndrejM - I have found a "MicroProfile TCK runner" for Payara, that seem to run various TCK's including MicroProfile Metrics (https://github.com/payara/ ...
Read more >
Metrics for Eclipse MicroProfile
Metrics in the base scope are intended to be portable between different MicroProfile-compatible runtimes. Application metrics. Application ...
Read more >
MicroProfile next release (June 2022) discussion
MicroProfile Metrics 5.0 will not be allowed to be included as it is a major release. A2: MicroProfile 6.0. Specification, June ...
Read more >
MicroProfile 5.0 Release with Updated Jakarta EE 9.1 ...
This release was mainly focused on updating dependencies from javax to jakarta, as well as overall stability and usability improvements.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found