make ElasticClient IDisposable

Currently the ElasticClient is created, it is not possible to get rid of it. I would love to be able to do something like:

using (var settings) { settings.GlobalHeaders(new NameValueCollection { { "Authorization", $"Bearer {token}" } }; var client = new ElasticClient(settings); var results = client.DoSomething(); // return results; }

The problem with the ElasticClient is very static, it would be helpful in a MVC API Controller, we can switch “security context” of the connection.

[dliulabs]

Hi @stevejgordon,

Okay, I tweak a little of my code and was lucky to have found the right syntax. This one works:

using Nest;
using Elasticsearch.Net;
using Elastic.Transport;

var blank_settings = new ConnectionSettings (new Uri (ELASTIC_URI))
    .PrettyJson(true);
var blank_client = new ElasticClient(blank_settings);

var r = await blank_client.Cat.IndicesAsync(
    c => c
    .AllIndices()
    .RequestConfiguration(r => r.BasicAuthentication(ELASTIC_USER, ELASTIC_PASS))
);

So if this per-call configuration does not keep anything in the ElasticClient. You are right, we can use a Singleton ElasticClient and just supply needed credentials at per-request basis.

Thank you for all your help.

[stevejgordon]

@dliulabs The code in my comment above should work on your API call. It’s not r => r.Authentication but r => r.BasicAuthentication("username", "password")