Publish triggers afterAllArtifactBuild hook too late

• Version: 20.41.0

• Target: Mac

I’m writing an afterAllArtifactBuild hook where the produced dmg on Mac is notarized using electron-notarize. This works fine when building (i.e. electron-builder build --mac): the hook triggers after all targets are built and the dmg is notarized.

When building and publishing to github by running electron-builder build --mac -p always however, electron-builder starts uploading the dmg to github even before the afterAllArtifactBuild hook is triggered.

When simply publishing without building, the afterAllArtifactBuild is not triggered at all!

Ideally the publish command should wait for the afterAllArtifactBuild hook to finish running, or not rebuild the targets at all. If publish did not rebuild the targets, one could notarize/generate checksums using the afterAllArtifactBuild hook then have the publish command only pickup the generated binaries; Now it overrides anything generated before!

[vcombey]

“Ideally the publish command should wait for the afterAllArtifactBuild hook to finish running !” I also think this should be the case. Is it the case ? I try to sign the exe on windows in afterAllArtifactBuild but the exe is upload before my script runs…

[danni]

Updated to add, you can work around this by setting publish: null on your pkg target, and then returning the path of the pkg in the afterAllArtifactBuild hook.

pkg:
  publish: null # This will be published by the afterAllArtifactBuild hook

/**
 * Notarize .pkg
 */
const fs = require('fs');

const notarize = require('electron-notarize');

module.exports = async function (context) {
  if (process.platform !== 'darwin') {
    console.log(`afterAllArtifactBuild: nothing to do on ${process.platform}`);
    return [];
  }

  const appBundleId = context.configuration.appId;
  const paths = await Promise.all(context.artifactPaths.map(async appPath => {
    if (!appPath.endsWith('.pkg')) return null;

    if (process.env.APPLE_ID === undefined) {
      console.warn("APPLE_ID not set, skipping notarization");
      return appPath;
    }

    console.log(`afterAllArtifactBuild: Notarizing ${appBundleId} at ${appPath}`);

    // Test we can access the file
    await fs.promises.access(appPath)
    await notarize.notarize({
      appBundleId,
      appPath,
      appleId: process.env.APPLE_ID,
      appleIdPassword: '@keychain:AC_PASSWORD',
    });

    return appPath;
  }));

  return paths.filter(appPath => appPath !== null);
}