Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Arrays in original target are mutated by library

See original GitHub issue

When you have this code

const item = { numbers: [1, 2] }
ObservableSlim.create(item)

calling Object.keys(item.numbers) yields ['0', '1', '__length'] instead of just ['0', '1'].

This is due to the following change: https://github.com/ElliotNB/observable-slim/commit/c69aafd14ca851b63ac76262d951b9d057fa2929#diff-a882dd68fa93398bef8261d2308d9600efd956dbe6ba6ef1f0fe368aa107225dR64

Expected: Original object should not be mutated.

Of course Object.keys() is not really useful on arrays, but it causes a strange error in jest saying serializes to the same string.

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

BinarySpikecommented, Nov 7, 2021

I need to test this on my side—it may be an improvement for me. There are differences between the native proxy and the polyfill proxy when it comes to __length and in my client code I have to manually filter it out to support IE11 / polyfill. This might remove the need for my manual check.

I can see no downsides for my use-cases!

1reaction

ElliotNBcommented, Feb 25, 2021

@MZanggl Excellent! I’ll get a PR opened up for it and get it published out on npm soon.