Remove opinionated configurations
See original GitHub issueIn ESLint it is common to have eslint-plugin-*
project that provide custom rules and eslint-config-*
projects that provide custom configurations (aka. rulesets). IMHO this project should only provide the custom rules for Ember projects, but no opinionated configurations. Instead opinionated configurations should be provided by projects like https://github.com/simplabs/eslint-config-simplabs and https://github.com/DockYard/eslint-plugin-ember-suave.
If we decide that we want to keep the configuration here then we should discuss what rules to recommend since this is an official Ember CLI project now and people are apparently starting to adopt those recommendations (see https://github.com/emberjs/ember.js/issues/15590#issuecomment-323342930)
/cc @rwjblue @michalsnik
Issue Analytics
- State:
- Created 6 years ago
- Reactions:5
- Comments:7 (6 by maintainers)
Top GitHub Comments
FWIW, I would be in favor of voting on rules and doing some sort of RFC process or something, that way we can recommend a preset for ember projects to try to standardize things across the community. Everyone is going to have different opinions on things like spacing, etc, but rules that are good Ember practices should be an easy set for most people to agree on enforcing, I, for one, would be fine giving up some of my own Ember preferences, like using
this.get
for hopefully gaining more consistency across projects.I guess that the most likely candidates to be turned off as being too opinionated would be
use-ember-get-and-set
and all theorder-in-*
rules (I still kind of like the idea of keeping them, but switched off by default). I feel that all the others provide real value, such as preventing unexpected behaviour or warning about deprecations and could be another way for the ember core team to provide additional guidance for developers when introducing deprecations and/or introducing new features. WDYT?