question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Styles don't play nice with disabled application-template-wrapper

See original GitHub issue

When using addon-docs on an app with application-template-wrapper set to false (which is default in octane), the app styles don’t work well. See below:

https://github.com/ember-learn/ember-cli-addon-docs/blob/75742729ec9443e653ad9383c0fbdafb1b404ef0/addon/styles/addon.scss#L51-L58

Screen Shot 2019-11-01 at 3 02 55 PM

This is simple to fix, but it would be better to not break for these cases. The fix is just wrapping the content of application.hbs with a div with classes ember-view:

<div class="ember-view">
  <DocsHeader />

  {{outlet}}
</div>

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
NullVoxPopulicommented, Feb 8, 2020

omg yes. Yesterday me was an idiot. thanks!

0reactions
rwwagner90commented, Feb 8, 2020

@NullVoxPopuli any interest in taking a look at a fix? Can you not manually wrap in <div class="ember-view">?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Optional Features - Configuration - Ember Guides
To disable a feature, run ember feature:disable some-feature. Available features: application-template-wrapper (Default: true) Wrap the top-level ...
Read more >
How to remove space bottom mat-form-field - Stack Overflow
Wrap the component you want to style in a custom class. So it wont affect any other mat-form-field components. Let's wrap this with...
Read more >
heartcombo/simple_form: Forms made easy for Rails ... - GitHub
This will add an initializer that configures Simple Form wrappers for ... so you can style labels, hints and other components inside the...
Read more >
Advanced form styling - Learn web development | MDN
In this article, we will see what can be done with CSS to style the types of form control that are more difficult...
Read more >
How To Build Forms in React | DigitalOcean
Next, inside the <form> tag, add a <fieldset> element with an <input> element surrounded by a <label> tag. By wrapping the <input> element...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found