[Feature Request] List tables without primary key

Tables without a primary key don’t show up in the Select Tables to Script dialog. There’s no further reason specified why the table isn’t in the dialog, even though the database projects builds fine.

Suggestion: List the tables without primary key in the dialoge, but make the checkbox unchecked and disable the control, with a note showing behind the table that the primary key is missing.

Steps to reproduce

Example: MissingTableConsole.zip

1. Open attached solution
2. Right-click on the MissingTableConsole project
3. EF Core Power Tools --> Reverse Engineer
4. Select MissingTableDatabase in the DacPac drop-down
5. Table config.Message is not showing up

Further technical details

EF Core Power Tools version: 1.0.664.0

Database engine: None (DacPac)

Visual Studio version: Visual Studio 2017 15.8.7

[ErikEJ]

I would pick this, if you’re okay with the suggestion.

Sounds fantastic! Keep in mind, that ideally we should do the same for SQL Compact and NpgSQL (and SQL Server databases)

why the check is for .Where(t => t.PrimaryKeyConstraints.Count() > 0) instead of == 1?

Maybe in order to accomodate multi column primary keys?

[ErikEJ]

I prefer to avoid that dependency (Json.net) when running under VS.

Better to keep the Tables property, but ignore the value in code. (So break, but not fail)