question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Refactor dialogs to implement MVVM pattern

See original GitHub issue

The current dialogs in the EFCorePowerTools project include business logic in their background classes. This makes the dialogs not really testable, as business logic requires an instance of the dialog to be created.

Implement the MVVM pattern for the dialogs to seperate the UI logic from the business logic.

Requires:

  • New shared project required (probably .NET Standard 2.0), e.g. EFCorePowerTools.Shared
  • Adding dependency injection
  • Loose coupling between model (data access), view model (view logic, model connector) and view (dialog only)

Benefits:

  • Components (dialogs and other layers) will be testable/better testable
  • Stability through more tests
  • Easier extensibility through seperate layers

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:36 (36 by maintainers)

github_iconTop GitHub Comments

1reaction
ErikEJcommented, Nov 4, 2018

@Herdo Please go ahead - but please do so in a separate PR (also notice that Telemetry is currently disabled due to some performance issues)

0reactions
ErikEJcommented, Apr 18, 2019

Finally closing this, thanks for the effort!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Refactor Like a Pro: The No-Brainer Guide to Converting ...
In the talk, I take a view controller using Model-View-Controller (MVC) and begin refactoring it to Model-View-ViewModel (MVVM). The view ...
Read more >
Unlock Proven Steps of Refactoring to MVVM in Swift (Part 2)
In part one of the demo, I took advantage of a recurring pattern. On one side of the if-statement, the code set a...
Read more >
Some help refactoring to MVVM : r/dotnet
I'm trying to refactor a small WPF app into MVVM but I'm having some issues ... I've seen some examples that use multiple...
Read more >
iOS MVVM Tutorial: Refactoring from MVC
Before diving into refactoring, it's essential you understand what the view model and view controller do in the MVVM pattern.
Read more >
How to implement dialog pick-an-option in Android MVVM ...
i'm trying to get into MVVM pattern and my problem is that I'm not really sure if I use it correctly. View is...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found