Advanced SSA Fonts/Typesetting are not displaying correctlySee original GitHub issue
Anime SSA subtitles often have custom fonts/typesetting that alter the video (transformation, masking, etc.) PR #742 had extracting subtitles from the original video file integrated, but commented out here.
When I built it with the line uncommented and
episodeId changed to
mediaItemId, the subtitles does work properly with the correct fonts now being burned into the video stream.
await ExtractFonts(dbContext, mediaItemId, ffmpegPath, cancellationToken);
Is there a reason why it was commented out? It looks like it was working completely fine.
- Created 9 months ago
Top GitHub Comments
For various different movies and tv shows, I’ve only had this pop up.
I think it is covered by your PR. So LGTM. Are you going to look at cleaning up the files, or just leave it in the fonts directory?
My initial guess is that I was unhappy with dumping all attachments in a fonts folder (not just fonts). Perhaps I can run a cleanup process after extraction.
Will revisit this soon, thanks for the detailed direction.